codeant-ai-for-open-source[bot] commented on code in PR #45507:
URL: https://github.com/apache/superset/pull/45507#discussion_r4320672953
##########
superset/db_engine_specs/oceanbase.py:
##########
@@ -201,3 +203,83 @@ class OceanBaseEngineSpec(MySQLEngineSpec):
{},
),
}
+
+
+def monkeypatch_dialect() -> None:
+ """
+ Monkeypatch oceanbase_py's SQLAlchemy dialect to work under SQLAlchemy 2.0.
+
+ ``OceanBaseDialect.has_table()`` and ``get_columns()`` both pass a raw SQL
+ string straight to ``Connection.execute()`` (e.g.
+ ``connection.execute(f"DESCRIBE {full_name}")``), which SQLAlchemy 2.0
+ rejects outright with ``ObjectNotExecutableError``. Every *other* raw-SQL
+ method in the same dialect module already uses
+ ``connection.exec_driver_sql(...)`` instead, so this looks like an
+ isolated oversight rather than a deliberate choice. ``has_table()`` also
+ never catches the error ``DESCRIBE`` raises for a table that doesn't
+ exist (MySQL/OceanBase error 1146), so even with that call fixed it can
+ only ever return ``True``, raising instead of returning ``False`` for
+ exactly the case ``MetaData.create_all()``'s default ``checkfirst=True``
+ relies on.
+
+ The ``oceanbase_py`` PyPI package has no public source repository to open
+ an issue or PR against, so this is filed upstream by email instead; patch
+ here until (if ever) a fixed release ships.
+ """
+ try:
+ from oceanbase_py.sqlalchemy import datatype
+ from oceanbase_py.sqlalchemy.dialect import OceanBaseDialect
+ except ImportError:
+ return
+
+ def has_table(
+ self: Any,
+ connection: Connection,
+ table_name: str,
+ schema: Optional[str] = None,
+ **kw: Any,
+ ) -> bool:
+ if schema is None:
+ schema = self.default_schema_name
+ quote = self.identifier_preparer.quote_identifier
+ full_name = quote(table_name)
+ if schema:
+ full_name = f"{quote(schema)}.{full_name}"
+ try:
+ res = connection.exec_driver_sql(f"DESCRIBE {full_name}")
+ except ProgrammingError:
+ return False
Review Comment:
**Suggestion:** Catching every `ProgrammingError` treats unrelated SQL
errors as a missing table, so `has_table` returns false and `get_columns` can
raise a misleading `NoSuchTableError`.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Incorrect condition
logic`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=402208b495074081a4f6b28f31a00e61&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=402208b495074081a4f6b28f31a00e61&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/db_engine_specs/oceanbase.py
**Line:** 250:251
**Comment:**
*Incorrect Condition Logic: Catching every `ProgrammingError` treats
unrelated SQL errors as a missing table, so `has_table` returns false and
`get_columns` can raise a misleading `NoSuchTableError`.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45507&comment_hash=8b7d4edc3eb2e39745281c563474602a51463b7e9627e580f87be3d781850c41&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45507&comment_hash=8b7d4edc3eb2e39745281c563474602a51463b7e9627e580f87be3d781850c41&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
