alexandrusoare commented on PR #45451: URL: https://github.com/apache/superset/pull/45451#issuecomment-6289051796
> * Are we OK with the Explore change locking out viewers who reach a chart only through dashboard access, or should it be gated behind a flag or config? Dropped it. You were right to push — I'd framed the affected users as a dashboard-RBAC edge case, but the chart branch is if chart.viewers: if is_viewer(chart): return with an elif for the dataset check, so the dataset check isn't consulted at all when a chart has explicit viewers. Chart viewers without a dataset grant open Explore today by design; that's chart-level sharing working, not a configuration quirk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
