codeant-ai-for-open-source[bot] commented on code in PR #45520:
URL: https://github.com/apache/superset/pull/45520#discussion_r4325820082
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/TimeseriesLegend.tsx:
##########
@@ -134,18 +150,31 @@ export type TimeseriesLegendProps =
TimeseriesCustomLegend & {
function TimeseriesLegend({
items,
maxHeight,
+ maxWidth,
onAll,
onHover,
onInverse,
onToggle,
+ orientation,
showSelectors,
}: TimeseriesLegendProps) {
- if (items.length === 0 || maxHeight <= 0) {
+ const isVertical =
+ orientation === 'left' || orientation === 'right';
+
+ const isEmpty = items.length === 0;
+ const noSpace =
+ isVertical ? (maxWidth !== undefined && maxWidth <= 0) : maxHeight <= 0;
+
+ if (isEmpty || noSpace) {
return null;
}
return (
- <LegendViewport data-test="timeseries-custom-legend" maxHeight={maxHeight}>
+ <LegendViewport
+ data-test="timeseries-custom-legend"
+ maxHeight={isVertical ? 0 : maxHeight}
Review Comment:
**Suggestion:** For left and right legends this discards the computed
chart-body height, so long lists have no height limit and grow past the chart
instead of scrolling.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Css layout issue`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=7f3bb4f52e8c4e2881f76a729ea03590&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=7f3bb4f52e8c4e2881f76a729ea03590&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/TimeseriesLegend.tsx
**Line:** 175:175
**Comment:**
*Css Layout Issue: For left and right legends this discards the
computed chart-body height, so long lists have no height limit and grow past
the chart instead of scrolling.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45520&comment_hash=8e94f52da69ec8f774dfc487e7b614b1a16db187a846b4d547e5be1ad632cd9a&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45520&comment_hash=8e94f52da69ec8f774dfc487e7b614b1a16db187a846b4d547e5be1ad632cd9a&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
