mikebridge commented on code in PR #45393:
URL: https://github.com/apache/superset/pull/45393#discussion_r4327350229
##########
superset-core/src/superset_core/semantic_layers/layer.py:
##########
@@ -80,6 +80,9 @@ class SemanticLayer(ABC, Generic[ConfigT, SemanticViewT]):
Abstract base class for semantic layers.
"""
+ # Parsed settings read by the host when requesting the runtime schema.
+ # Providers supply this instance attribute; the SDK does not initialize it.
+ configuration: ConfigT
Review Comment:
Documented in 3645460cdb14: the contract for this PR is a writable
self.configuration holding the parsed configuration instance. A raw dictionary
is a type error by design. Read-only properties are not supported by this
contract; property support is tracked as a separate follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
