seunggabi commented on PR #45272: URL: https://github.com/apache/superset/pull/45272#issuecomment-6297179071
Friendly ping for a committer review. @aminghadersohi @rusackas — since you've worked on the API-key / MCP scope code, could one of you take a look? Status: CI is green (49 passing, none failing), both of EnxDev's inline notes are addressed and EnxDev gave an LGTM on Oct 15. It's only waiting on a committer approval now. The change keeps the key-creation dialog from offering MCP scopes the user can't self-issue, which today ends in a 500 on save; the endpoint derives the allowed list from the same `_validate_requested_api_key_scopes` path that `create_api_key` uses, so the two can't drift. Happy to adjust anything. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
