rusackas commented on issue #44512: URL: https://github.com/apache/superset/issues/44512#issuecomment-6297448645
Relaying from the email thread: > 1. Feature flag vs. config key for REQUIRE_DOWNLOAD_REASON. I vote config. If this isn’t a feature rollout path, or something that might be on the road to deprecation, it should be considered config. For a random historical sidebar, there was some debate about boolean config items getting lumped into feature flags at one point, but I think we’ve largely eschewed that idea, and see config as the right place for “settings for permanent features” and feature flags being more for feature release/removal and trying to trim down that list over time since it multiplies complexity of releases/testing. > 2. Recording the reason in the existing Action Log entry (no new table) - any concerns? I think this would be preferred in my book… this reason sounds like it IS an action log, so no need to add the maintenance footprint and testing/migration complexities of a new table. > 3. Anything missing from the scope (Explore, dashboard charts,dashboard-wide Excel, SQL Lab, scheduled reports)? Not sure… there may be any number of places in the future to add a “reason” input and store it in the same way. I think the main thing would be to make sure this is as centralized and “DRY” as possible so it can be cleanly reused with a minimal code footprint wherever it’s needed in the future. Which could go beyond this download reasoning to other reasons (e.g. installing an Extension, or punching a hole in the CSP so an Extension can reach an external service). > If there are no objections by Oct 28, I'll open the [VOTE] thread. Sounds like a plan! If the above are in place, you’ll likely get my +1 ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
