mikebridge opened a new pull request, #45533:
URL: https://github.com/apache/superset/pull/45533

   ### SUMMARY
   
   Task detail and list responses include the stored failure message. For 
embedded guests, serialize that field through Superset's existing error-message 
sanitizer so they receive the standard generic text. Other users continue to 
receive the stored message.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Not applicable; this changes API response text only.
   
   ### TESTING INSTRUCTIONS
   
   1. With `EMBEDDED_SUPERSET` enabled, subscribe an embedded guest to a failed 
task and fetch its detail and list responses. Both should contain the standard 
generic error text.
   2. Check that an ordinary user's task response retains the stored error text.
   3. Run `TZ=UTC python -m pytest tests/unit_tests/tasks/test_schemas.py 
tests/integration_tests/tasks/api_tests.py -q` against a migrated test database.
   
   Validation: 34 task API tests and 204 MCP inventory tests passed; 
changed-file pre-commit (including MyPy) and the translation-template drift 
check passed.
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [x] Required feature flags: `EMBEDDED_SUPERSET` for the embedded guest 
scenario
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to