mikebridge opened a new pull request, #45535: URL: https://github.com/apache/superset/pull/45535
### SUMMARY Make the dashboard composition tools use the existing chart access check as well as their datasource validation. Requests return a permission message before changing the dashboard when a selected chart is unavailable to the caller. The add-chart response description explains that both kinds of access are needed. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable; MCP responses only. ### TESTING INSTRUCTIONS Run the MCP unit tests. The new parametrized tests exercise both dashboard composition tools for table and semantic-view charts, checking permission refusals and successful additions. They assert no dashboard mutation on refusal. For manual verification, use a caller with dashboard write capability and compare a readable chart with one whose viewers exclude that caller. `python -m pytest -q tests/unit_tests/mcp_service`: 10,930 passed, 12 skipped. Changed-file pre-commit checks, including MyPy, Ruff and pylint, pass. Removing the new guards produces 8 failing denial cases while 4 readable-chart cases still pass; restoring the guards passes the focused checks. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
