mikebridge commented on code in PR #45482: URL: https://github.com/apache/superset/pull/45482#discussion_r4329170692
########## docs/docs/using-superset/version-history.mdx: ########## @@ -282,8 +282,12 @@ worth knowing: you moved away from. Returning to one of those states depends on its history still being available; retention and permanent deletion can remove it. - **A dashboard restore may be partial.** If the version referenced charts that - have since been deleted, the layout is restored without them and Superset - tells you how many were not reattached. + have since been permanently deleted, the layout is restored without them and Review Comment: You're right, I was reading my own sentence too loosely: the snapshot's `position_json` comes back verbatim, and only membership leaves the deleted charts out. I took your wording in 6ef3eff663. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
