geido commented on code in PR #45478:
URL: https://github.com/apache/superset/pull/45478#discussion_r4325465260
##########
superset/coordination/base.py:
##########
@@ -497,9 +498,16 @@ def listen_for_signal(
:param name: optional thread name suffix for logging.
"""
stop_event = threading.Event()
+ enter_context = cls._capture_background_context()
+
+ def run() -> None:
+ with enter_context():
Review Comment:
I think a transient failure while entering the configured context could end
this thread before `_run_listen_loop` reaches its retry handler. The task keeps
the listener handle, so a later abort wouldn't be picked up until the task
ends. Could we retry entering it with the loop's backoff until `stop_event` is
set?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
