Aleem89 commented on issue #45488:
URL: https://github.com/apache/superset/issues/45488#issuecomment-6300387681
Hi Sam, I was wondering the same thing but I looked into it further with our
good friend Claude and he said the fixes would not overlap. Here's the summary
it stated:
> #45505 only changes the tooltip HTML, which goes through sanitizeHtml, so
it had to stay inside the CSS allowlist. The List legend is a React component
(TimeseriesLegend.tsx) with no sanitizer
involved, so an SVG swatch like Sam suggested is the better fit there and
wouldn't share code with the tooltip marker.
The only common file is Timeseries transformProps.ts, and the hunks are
far apart: #45505 removes the old getSymbolMarker helper and changes the
tooltip callback, while a legend fix would read
symbol and lineStyle.type from the built series inside
buildTimeseriesCustomLegend and pass them to the swatch. Nothing the legend
needs was removed or changed, so the two should merge
cleanly in either order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
