sadpandajoe commented on code in PR #44966:
URL: https://github.com/apache/superset/pull/44966#discussion_r4330776924
##########
superset-frontend/src/explore/components/controls/ContourControl/ContourPopoverControl.tsx:
##########
@@ -47,10 +47,10 @@ const StyledRow = styled(Row)`
`;
const isIsoband = (contour: ContourType) => {
- if (Object.keys(contour).length < 4) {
- return false;
- }
- return contour.upperThreshold && contour.lowerThreshold;
+ return (
Review Comment:
With the early return gone, `isIsoband` is now a block body containing only
`return (...)`, which the repo's oxlint `arrow-body-style` rule rewrites to an
expression body. The pre-commit job runs with `--fix`, so it modifies this file
and fails, which is what's turning the pre-commit check red on this head. Could
you run the frontend lint/format hook locally and commit the autofix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
