codeant-ai-for-open-source[bot] commented on code in PR #45545:
URL: https://github.com/apache/superset/pull/45545#discussion_r4331503462
##########
superset/commands/semantic_layer/delete.py:
##########
@@ -116,47 +119,54 @@ def _dashboard_target_ids(view_ids: sa.Select) ->
set[int]:
def _dependent_assets(
view_ids: sa.Select,
-) -> tuple[int, list[dict[str, str | int]], int]:
+) -> tuple[int, list[dict[str, str | int]], int, int]:
"""Count dependents, naming only assets visible through their list APIs."""
- chart_ids: sa.Select = sa.select(Slice.id).where(
- Slice.datasource_type == "semantic_view",
- Slice.datasource_id.in_(view_ids),
- Slice.deleted_at.is_(None),
+ # Core table selects bypass the ORM do_orm_execute soft-delete filter:
+ # archived charts and dashboards must still block semantic-source deletion.
+ chart_ids: sa.Select = sa.select(Slice.__table__.c.id).where(
+ Slice.__table__.c.datasource_type == "semantic_view",
+ Slice.__table__.c.datasource_id.in_(view_ids),
)
chart_dashboard_ids: sa.Select = (
sa.select(dashboard_slices.c.dashboard_id)
- .join(Slice, dashboard_slices.c.slice_id == Slice.id)
- .join(Dashboard, dashboard_slices.c.dashboard_id == Dashboard.id)
+ .join(Slice.__table__, dashboard_slices.c.slice_id ==
Slice.__table__.c.id)
+ .join(
+ Dashboard.__table__,
+ dashboard_slices.c.dashboard_id == Dashboard.__table__.c.id,
+ )
.where(
- Slice.id.in_(chart_ids),
- Dashboard.deleted_at.is_(None),
+ Slice.__table__.c.id.in_(chart_ids),
)
.distinct()
)
dashboard_target_ids: set[int] = _dashboard_target_ids(view_ids)
Review Comment:
**Suggestion:** The target IDs are materialized before the count; under READ
COMMITTED, a dashboard can gain a semantic target afterward and deletion can
proceed despite that dependency.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Race condition`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=84fa753efe994c8aa51d6fb34a57e556&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=84fa753efe994c8aa51d6fb34a57e556&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/semantic_layer/delete.py
**Line:** 142:142
**Comment:**
*Race Condition: The target IDs are materialized before the count;
under READ COMMITTED, a dashboard can gain a semantic target afterward and
deletion can proceed despite that dependency.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45545&comment_hash=aa97f52e0634ecea62f2d50c1005fdc10c854c8b0c707e759b123b84aac5ab2e&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45545&comment_hash=aa97f52e0634ecea62f2d50c1005fdc10c854c8b0c707e759b123b84aac5ab2e&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
