rusackas commented on PR #45070: URL: https://github.com/apache/superset/pull/45070#issuecomment-6305014887
Heya @sadpandajoe, this one had been quiet for a couple weeks so I pushed a small fix rather than just leaving it as a comment. `get_cancel_query_id` was minting a UUID unconditionally, but only `execute_with_cursor` (the SQL Lab path) actually threads that id into the driver. The GTF chart-data path goes through the base `execute()`, which never forwards it, so `cancel_query`'s `KILL QUERY WHERE query_id = ...` would have nothing real to kill there, and its "nothing to confirm" fallback would report a cancel that never happened. `_CancellationQuery` already stubs `query.id` as `None` for exactly that path, so I just had `get_cancel_query_id` decline on that instead of minting an id it can't use. Added a test for the decline case too. Holler if you'd rather handle it differently, happy to adjust. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
