rusackas commented on PR #45197: URL: https://github.com/apache/superset/pull/45197#issuecomment-6306588159
@hainenber thanks for the v2 adaptation! The jest mocks were still stubbing the v1 default export, which is what sank the shards, and the inline `ChildComponent` closures were remounting their lists every render since v2 wraps that prop in `memo`. Pushed a commit moving those to `renderProp` and fixing up the mocks/tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
