rusackas commented on PR #43515: URL: https://github.com/apache/superset/pull/43515#issuecomment-6307131829
Heya @gerbermichi, this one looked done but `babel-extract` was failing, so I pushed a fix. The new "Minimum Interval" labels and descriptions never made it into `messages.pot`, since `scripts/translations/babel_update.sh` hadn't been re-run after adding the controls. Ran it and committed the regenerated `.pot`/`.po` files. On the review threads: the two CodeAnt findings are already resolved (one by a later commit, confirmed in my earlier approval too), and I don't think the Bito "inverted assertion" catch holds up either, already said as much when I approved. Should just be CI now. Holler if anything else comes up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
