rusackas commented on PR #38451: URL: https://github.com/apache/superset/pull/38451#issuecomment-6308540022
@MelikHajlawi this branch had drifted far enough behind `master` that a rebase wasn't practical (and I don't have the OAuth scope to push a rebase that touches `.github/workflows/*` files along the way), so I rebuilt your fix fresh against current `master` in #45555, keeping you as a co-author. It also folds in the fixes for everything raised in this thread, the query-identifier/truncation interaction sadpandajoe and codeant flagged, the displayLabelMap gap I flagged back in July (already covered by how `master` evolved since), and explains why I left the `DEFAULT_FORM_DATA` default as `false` rather than `true`. Thanks for the original work here, sorry it took this long to land. Closing this one in favor of #45555. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
