codeant-ai-for-open-source[bot] commented on code in PR #45560:
URL: https://github.com/apache/superset/pull/45560#discussion_r4334490997
##########
superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx:
##########
@@ -1351,6 +1351,21 @@ function DatasourceEditor({
addDangerToast,
]);
+ // A sync must merge against the live column state: `datasource.columns` is
+ // the snapshot from when the editor opened, so merging against it reverted
+ // any column edit made since. Refs, because the request resolves after the
+ // callback's closure was captured.
+ const currentColumns = useMemo(
+ () => [...databaseColumns, ...calculatedColumns],
Review Comment:
**Suggestion:** Including calculated columns lets one shadow a deleted
physical column with the same name; sync treats the source column as calculated
and filters it out, so the physical column is lost.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Incorrect variable
usage`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=7953460c23874f40a87fda9b072d10e9&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=7953460c23874f40a87fda9b072d10e9&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx
**Line:** 1359:1359
**Comment:**
*Incorrect Variable Usage: Including calculated columns lets one shadow
a deleted physical column with the same name; sync treats the source column as
calculated and filters it out, so the physical column is lost.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45560&comment_hash=b0ae09a98ad868664f2ffd57c084acf5fb43678034a415b10017fb397a363024&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45560&comment_hash=b0ae09a98ad868664f2ffd57c084acf5fb43678034a415b10017fb397a363024&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
