codeant-ai-for-open-source[bot] commented on code in PR #45558:
URL: https://github.com/apache/superset/pull/45558#discussion_r4334517399
##########
superset-frontend/src/components/Datasource/DatasourceModal/index.tsx:
##########
@@ -172,6 +172,8 @@ const DatasourceModal:
FunctionComponent<DatasourceModalProps> = ({
};
}, [datasource.id, etag, show]);
const baselineSql = seededSql ?? datasource.sql;
+ // The API reports a physical dataset's SQL as `null`, the editor as `''`.
+ const sqlChanged = (baselineSql ?? '') !== (currentDatasource.sql ?? '');
Review Comment:
**Suggestion:** If a fresh read returns `sql: null` while caller props
retain old SQL, this comparison uses the stale baseline and enables column sync
for a physical dataset.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Incorrect variable
usage`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=1126ccba4eff4bbeb99c35e8c38e2c35&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=1126ccba4eff4bbeb99c35e8c38e2c35&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/components/Datasource/DatasourceModal/index.tsx
**Line:** 176:176
**Comment:**
*Incorrect Variable Usage: If a fresh read returns `sql: null` while
caller props retain old SQL, this comparison uses the stale baseline and
enables column sync for a physical dataset.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45558&comment_hash=ab84959489fbf726cb6a97fce3bd80d725cf4d71640d69485be3a8f4b16b1242&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45558&comment_hash=ab84959489fbf726cb6a97fce3bd80d725cf4d71640d69485be3a8f4b16b1242&reaction=dislike'>๐</a>
##########
superset/connectors/sqla/models.py:
##########
@@ -2449,6 +2449,10 @@ def fetch_metadata(self) -> MetadataResult:
db_engine_spec.alter_new_orm_column(new_column)
if expression:
new_column.expression = expression
+ # Defaults for a newly discovered column only; an existing
+ # column keeps whatever the dataset owner chose.
+ new_column.groupby = True
+ new_column.filterable = True
Review Comment:
**Suggestion:** Existing columns with NULL flags now keep them during sync;
`filterable_column_names` and the groupability query treat NULL as false,
making those columns unavailable.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Logic error`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=9eb11e2d983a4016b5e6f96845090552&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=9eb11e2d983a4016b5e6f96845090552&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/connectors/sqla/models.py
**Line:** 2454:2455
**Comment:**
*Logic Error: Existing columns with NULL flags now keep them during
sync; `filterable_column_names` and the groupability query treat NULL as false,
making those columns unavailable.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45558&comment_hash=12b352fac4eba9c338131fe2c99cc0e8dcaf493bcded08d9adce09daf7d2f7a1&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45558&comment_hash=12b352fac4eba9c338131fe2c99cc0e8dcaf493bcded08d9adce09daf7d2f7a1&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
