xiaobai0529 commented on PR #45519: URL: https://github.com/apache/superset/pull/45519#issuecomment-6312881665
## Before / after screenshots from local Storybook testing I independently rendered the PR's target case in Storybook from both revisions, using the same fixture, viewport, and chart dimensions. **Setup** - Before: `d5bccecf58126db88a596164daf6fdda9aa0d341` - After: `aab7f5ba4a9816a90627dcb4d6c79585963657ae` - Viewport: 960x900 - Chart width: 900px, height: 260px - Bar chart, x-axis: temporal column, Time Grain: `P1D` - Top chart: yearly rows (2019-2024); bottom chart: monthly rows (24 months) **Before**  **After**  The before revision draws the yearly and monthly bars as hairlines because the Day-grain cap is far narrower than the spacing between rows. The after revision keeps the default 100px cap for Day and coarser grains, so the bars render at a normal width. This was Storybook-level QA, not a full Superset web-server deployment. The fixture exercised `EchartsTimeseriesChartPlugin` and `TimeseriesTransformProps`, and both screenshots were captured after confirming that two chart canvases had rendered. I did not modify the PR branch. The screenshot files are stored on a separate evidence branch of my public fork, not in the Superset repository. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
