sushu0 commented on code in PR #45467:
URL: https://github.com/apache/superset/pull/45467#discussion_r4335819116
##########
docs/developer_docs/api.mdx:
##########
@@ -128,6 +128,10 @@ update preserves the stored secrets; send new values to
replace them.
| `GET` | [Get related fields data
(chart-related-column-name)](/developer-docs/api/get-related-fields-data-chart-related-column-name)
| `/api/v1/chart/related/{column_name}` |
| `PUT` | [Warm up the cache for the
chart](/developer-docs/api/warm-up-the-cache-for-the-chart) |
`/api/v1/chart/warm_up_cache` |
+Chart-data `compare` post-processing handles zero baselines consistently for
raw SQL
+`DECIMAL` columns and floating-point inputs in percentage and ratio
comparisons.
+Absolute-difference comparisons retain the input arithmetic.
Review Comment:
Moved in af1f2d8863d5576e82a5a94d25317213ee47a2a4 to the handwritten
`docs/docs/using-superset/exploring-data.mdx` page, under **Time Comparison**,
as an **API post-processing** note. The wording remains explicitly scoped to
chart-data API `compare` requests on raw SQL DECIMAL columns. The generated
`docs/developer_docs/api.mdx` is restored to the PR baseline and is no longer
part of the PR diff.
Validation: the existing docs-link checker and staged-file pre-commit checks
passed. I also ran the unchanged `generate-api-index.mjs` with the repository's
actual OpenAPI/sidebar inputs in an isolated docs tree; it regenerated the API
index while leaving the handwritten guide's SHA-256 and the note unchanged. The
Decimal implementation and Python tests are unchanged in this
documentation-only commit, so I did not repeat the previously completed Python
suites.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
