gabotorresruiz commented on code in PR #45552:
URL: https://github.com/apache/superset/pull/45552#discussion_r4338680393
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberTotal/transformProps.ts:
##########
@@ -73,7 +73,11 @@ export default function transformProps(
} = queriesData[0] || {};
const granularity = extractTimegrain(rawFormData as QueryFormData);
const metrics = chartProps.datasource?.metrics || [];
- const originalLabel = getOriginalLabel(metric, metrics);
+ const originalLabel = getOriginalLabel(
+ metric,
+ metrics,
+ chartProps.datasource.verboseMap,
Review Comment:
Just a small NIT: the line right above uses
`chartProps.datasource?.metrics`, so this one reads oddly unguarded.
```suggestion
chartProps.datasource?.verboseMap,
```
Same two lines in `BigNumberWithTrendline/transformProps.ts` and
`BigNumberPeriodOverPeriod/transformProps.ts`. Purely defensive, since
`ChartProps` defaults `datasource` to `{}` and nothing in the repo reaches it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
