rusackas commented on PR #35832: URL: https://github.com/apache/superset/pull/35832#issuecomment-6320090072
Closing this one. #41998 (merged in July) already fixed the large-workspace timeout problem this PR was going after, by fetching the full channel list once via Slack's own cursor internally, caching it, and letting the picker page through that cached list with `page`/`page_size`. That ships today. This branch's own approach (exposing Slack's real cursor through the API so the first request doesn't have to wait on the whole workspace) is more rigorous for a truly massive workspace, and there are good findings in this thread that would still apply to a from-scratch version of that. But the branch itself is thousands of commits behind `master` now and the diff doesn't apply anymore, so reviving it means rebuilding the whole thing on top of `#41998` rather than a rebase. Given `#41998` already covers the common case, that's not worth doing without a concrete report of the simpler cached approach actually timing out in practice. @gabotorresruiz thanks for the work here, and @sadpandajoe for sticking with the review through all of it. If someone hits the truly-massive-workspace case `#41998` doesn't cover, this thread is a good starting point for a fresh PR. Closes #35832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
