rusackas commented on PR #45198: URL: https://github.com/apache/superset/pull/45198#issuecomment-6320485747
Looked closer at this one. The jest failures are just the first symptom (d3 7.x ships ESM-only, so `import d3 from 'd3'` can't be required without a transform tweak), but underneath that it's a real API break too: `WorldMap.ts` and `CountryMap.ts` both use v3-era namespaced APIs that don't exist past v4 - `d3.event`, `d3.geo.path()`/`d3.geo.centroid()`, `d3.behavior.zoom()`, `d3.mouse()`, `d3.scale.linear()`-style scales, and the v3 callback form of `d3.json(url, cb)`. Worse, `WorldMap.ts` also pulls in `datamaps/dist/datamaps.all.min`, a vendored, long-unmaintained library built against the same v3 global API shape - that one can't just be patched in our own code. lint-frontend doesn't catch any of this because `d3` isn't typed, so it's all silently `any`. This needs a real v3->v7 migration of both chart plugins (and possibly dropping/replacing `datamaps`), not a bump. Tagging `hold:needs-work`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
