rusackas commented on PR #45329: URL: https://github.com/apache/superset/pull/45329#issuecomment-6320434740
`react-dnd` dropped the old `DragSource`/`DropTarget`/`DragLayer` HOC API in favor of hooks (`useDrag`/`useDrop`/`useDragLayer`) a few majors back, and the dashboard's whole DnD grid is still built on the HOC API: `dnd/DragDroppable.tsx`, `dragDroppableConfig.ts`, `handleDrop.ts`, `handleHover.ts`, `AddSliceDragPreview.tsx`, plus `SliceAdder`, `ChartHolder`, `Divider`, `DynamicComponent`, `DraggableNewComponent`... about a dozen files total. Recoverable in principle, but it's a real hooks rewrite of a core dashboard-editing path, not a bump. #45128 (`react-dnd-html5-backend`) is blocked on this moving first. Tagging `hold:needs-work` on both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
