rusackas opened a new pull request, #45588:
URL: https://github.com/apache/superset/pull/45588

   ### SUMMARY
   `plugins/plugin-chart-country-map`'s GeoJSON files, `countries.ts`, and 
`docs/data/countries.json` are regenerated locally via `npm run update-maps`, 
which executes `Country Map GeoJSON Generator.ipynb` against Natural Earth plus 
several community geo repos. Right now that only happens when someone remembers 
to run it by hand.
   
   This adds `.github/workflows/update-country-maps.yml`, a 
**`workflow_dispatch`-only** job (no schedule) that:
   - Runs the notebook with `speed_run` forced to `True` so it skips the 
interactive preview rendering, against a patched scratch copy — the committed 
notebook itself is never modified.
   - Opens (or updates) a PR with the regenerated files if there's drift.
   - Flags any cell errors from the existing `--allow-errors` run directly in 
the PR body, since those mean some country's data may be stale rather than 
updated.
   
   This is intentionally **not** a cron like #45584 (translation catalogs). A 
border/region change here needs an actual human look at the rendered diff: a 
few of the notebook's sources track a floating `main` ref rather than a pinned 
commit (`eriks47/latvia`, `jdruii/phgeojson`), one is a live WHO ArcGIS query, 
and the notebook itself carries years of hand-tuned, country-specific 
corrections (mislabeled ISO codes, merged regions, islands repositioned for 
layout). A maintainer triggers this when they know upstream data moved and 
reviews the diff before merging — same shape as `bump-python-package.yml`'s 
existing dispatch-only bot.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A
   
   ### TESTING INSTRUCTIONS
   - `zizmor`/pre-commit pass on the new workflow file.
   - The `speed_run` patch logic was tested directly against the real committed 
notebook (confirmed it finds and patches the right cell, and that the committed 
notebook file is left untouched).
   - The workflow itself hasn't run in GitHub Actions yet (it only runs from a 
branch GitHub recognizes) — worth triggering once after merge to confirm the 
full execute → diff → PR path, including a deliberately-stale run to check the 
error-reporting path.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to