rusackas opened a new pull request, #45589:
URL: https://github.com/apache/superset/pull/45589

   ### SUMMARY
   Refreshes the Home page's Recent Activity section automatically after a 
dashboard or chart is deleted, instead of requiring a manual page reload. This 
is a rebase + fix-up of @guptapuja's work in #39528, opened fresh because the 
token used here lacks the `workflow` scope needed to push directly to their 
fork.
   
   Closes #39528 - thanks for the work here @guptapuja!
   
   On top of the rebase, this adds one small fix and some test coverage that 
review rounds on the original PR had asked for:
   - `ChartTable`'s delete flow calls `getData(chartFilter)` instead of 
`refreshData` whenever the active tab isn't "Mine" - that path was passing the 
raw, unwrapped `getData` through, so deleting a chart from the default/Other 
tab never fired the new `onActivityRefresh` callback at all. Wrapped it the 
same way `DashboardTable` already wraps its own `getData` (`handleGetData`).
   - Added test coverage for the `onActivityRefresh` wiring in both 
`ChartTable.test.tsx` and `DashboardTable.test.tsx`, which is what caught the 
gap above.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   See #39528 for before/after screenshots.
   
   ### TESTING INSTRUCTIONS
   1. Go to the Home page.
   2. Delete a dashboard or chart from the Dashboards/Charts section (try both 
the "Mine" tab and the default/Other tab).
   3. Observe the Recent Activity / Recents section updates automatically, 
without a page reload, in both cases.
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: Closes #39528 (and the underlying #39435)
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to