aminghadersohi commented on code in PR #44550:
URL: https://github.com/apache/superset/pull/44550#discussion_r4342244876
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -439,6 +454,15 @@ export default function transformProps(
) {
derivedComparisonSeries.add(entry[0]);
entry[1].shift();
+ } else if (
+ entry[1].length > groupBy.length &&
+ Array.isArray(timeCompare) &&
+ metricOffsetLabels.has(entry[1][0])
Review Comment:
With no dimensions, one currency metric and a separate sort-only metric,
Percentage comparisons get flat `<metric>, <offset>` labels. Their label-map
tuple is split, so this check misses them and the tooltip shows `$0.25` instead
of `25%`.
```suggestion
Array.isArray(timeCompare) &&
(metricOffsetLabels.has(entry[1][0]) ||
(groupBy.length === 0 && metricOffsetLabels.has(entry[0])))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
