rusackas commented on PR #45371: URL: https://github.com/apache/superset/pull/45371#issuecomment-6324440335
That first fix was itself broken - CI caught it: `route.fetch()`/`route.fulfill()` raced the page's own in-flight request for the same URL and threw `Route is already handled!`/`ECONNRESET` instead of actually fixing anything. Pushed a simpler, more robust fix instead: dropped `interceptGet()` entirely and kept `waitForGet` as-is (status/headers were never the problem). For the body, `expectValidExportZip` now takes `page` and re-fetches the same (idempotent) export URL independently via `page.request.get()` - the browser context's own `APIRequestContext`, which shares its cookies - instead of reading `response.body()` off the response the page itself already consumed. That sidesteps the race entirely without touching how the original request is observed. `intercepts.ts` is untouched now; smaller diff than before. CI's running on the new commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
