mikebridge commented on PR #45395: URL: https://github.com/apache/superset/pull/45395#issuecomment-6327825720
Following up on [your review](https://github.com/apache/superset/pull/45395#pullrequestreview-5597084428): Addressed the two pre-merge fixes in 06568a7c8a8a57e50f5efac3435eb05cc42a2c9d. The OR witness uses the host-normalized IN/IS_NULL shape with two non-NULL membership values and an outer comparison. The example data exposes lost parentheses in either filter order, dropped top-level comparisons, and a dropped membership value. Those mutations have regressions against the real SQLite example. ADHOC_COLUMN_EXPRESSIONS skips with an explicit “no SDK query shape yet” reason; no query violating list[Dimension] is required. The representable ad-hoc ordering check stays in place. The generation check also requires an additive catalog, and the guide makes the None-token limitation explicit. The SDK suite passes with 77 tests and four explicit skips. I kept the existing required case keys for this patch. Dedicated IN/time-range/empty-result cases and the fixture-versioning policy need to be agreed together before adding required fixtures. The missing-case diagnostics, simpler skip recipe and pytest lower bound remain non-blocking follow-ups; the empty-result gap is not claimed fixed here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
