rusackas commented on code in PR #44281:
URL: https://github.com/apache/superset/pull/44281#discussion_r4342929504
##########
tests/unit_tests/db_engine_specs/test_mssql.py:
##########
@@ -879,3 +884,339 @@ def
test_get_catalog_from_engine_params_empty_database_query_param_falls_back_to
)
assert "database" not in url.query
assert MssqlEngineSpec.get_catalog_from_engine_params(url, {}) == "path_db"
+
+
+def _basic_parameters(**overrides: Any) -> dict[str, Any]:
Review Comment:
```suggestion
def _basic_parameters(**overrides: Any) -> dict[str, Any]:
"""Build basic connection parameters, overridable per test."""
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
