rusackas commented on PR #45016:
URL: https://github.com/apache/superset/pull/45016#issuecomment-6329092893
redux-thunk 3.x peer-depends on redux ^5, and this package itself bundles
redux ^5.0.1 and redux-thunk ^3.1.0, so none of these three could really land
alone without leaving npm holding an inconsistent tree. Bumped redux and
redux-thunk on this branch too, so it now covers #45228 and #45331 as well, and
I'll close those in favor of this one.
Two actual breaking changes needed code fixes on top of the version bumps:
- redux-thunk 3.x dropped its default export (`thunk` is now a named export
only), so every `import thunk from 'redux-thunk'` needed to become `import {
thunk } from 'redux-thunk'` (~40 files, mostly tests).
- `@reduxjs/toolkit`'s `configureStore` now requires `enhancers` to be a
callback rather than a plain array, same shape as `middleware` already was.
Fixed in `src/views/store.ts`.
CI should be green on this one now. Good to merge once someone approves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
