rusackas commented on PR #44068: URL: https://github.com/apache/superset/pull/44068#issuecomment-6329418510
Thanks @MallikarjunaReddyN, the tests with deliberately different `rowcount` and `sql_rowcount` values are exactly what this needed. Last bit is @EnxDev's nit to `await` the `userEvent.click` in the multi-query test, then this looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
