rusackas opened a new pull request, #45600:
URL: https://github.com/apache/superset/pull/45600

   ### SUMMARY
   Two small things in the `test-storybook` job, which is the longest job in 
the Frontend workflow at about 6.5 minutes:
   
   - The story smoke tests run through Playwright with no `workers` setting, so 
they get Playwright's default of half the cores: 272 stories on 2 workers took 
5.3 minutes on the 4-core runner. The config now uses every core when `CI` is 
set and keeps the default locally.
   - Before the tests, `npx playwright install-deps` spent about 67 seconds 
installing OS packages for all three browsers (the Chromium download itself is 
10 seconds). `npx playwright install --with-deps chromium` installs only 
Chromium's packages.
   
   The CI run on this PR is the measurement; I'd expect the job to drop by 
roughly 2 to 3 minutes. If 4 workers turn out flaky on the shared runner we can 
pin a number instead of `'100%'`.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A
   
   ### TESTING INSTRUCTIONS
   Compare the `test-storybook` job duration on this PR against a recent master 
run (around 6m30s). Locally, `npm run test-storybook` behaves as before since 
`CI` isn't set.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to