rusackas opened a new pull request, #45604:
URL: https://github.com/apache/superset/pull/45604
## Description
Adopts #39657 (fix: remove getPopupContainer causing double scrollbar,
#35833), by @7487, with the narrower scope @rusackas and @7487 landed on in
review there.
The double scrollbar only comes from the `triggerNode.parentNode` fallback
(and the equivalent explicit `parentNode` usage in `ColorSchemeControl`,
`ColorSchemeSelect`, and `GroupByFilterCard`): an absolutely positioned popup
laid out inside an `overflow: auto` box grows a scrollbar of its own next to
the virtual list's. The `.closest('.ant-modal-container')` branch doesn't
exhibit this, so it's kept as-is, preserving the antd 6 modal-containment
contract (and `antdDomContract.test.tsx`) that #39657's original broader diff
would have flipped.
Pushing this as a fresh PR rather than to @7487's branch directly: the
fork's branch has drifted far enough from current `master` (a
`.github/workflows/bashlib.sh` divergence) that a GitHub App token without
`workflow` scope can't push to it.
## BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — behavioral/bugfix change, no visual change beyond the reported double
scrollbar going away.
## TESTING INSTRUCTIONS
Open a Select inside a tall modal where the trigger's non-modal ancestor has
`overflow: auto` (the original repro in #35833) — one scrollbar now, not two.
Modal-contained popups (e.g. role/group pickers) are unaffected;
`antdDomContract.test.tsx` still asserts that containment.
## ADDITIONAL INFORMATION
- [x] Has associated issue: Fixes #35833
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
