rusackas commented on PR #45603: URL: https://github.com/apache/superset/pull/45603#issuecomment-6331927701
CI numbers, from the `lint-frontend` job's "tsc" step on this PR against #45600's run of the same step a few minutes earlier (same slow-runner window, TypeScript 6): | phase inside the step | TypeScript 6 (#45600) | TypeScript 7 (this PR) | |---|---|---| | `npm i` inside the container | 5m04s | 5m04s | | babel (lib + esm) | 28 s | 28 s | | `tsc --build` across packages | 68 s | 30 s | | `tsc --noEmit` | 58 s | 18 s | | whole step | 459 s | 380 s | So the compiler itself is 2 to 3x faster, same as locally, but the step is dominated by something else: the `npm i` the step runs inside the CI image adds 104 packages and takes five minutes, and the `lint` step just above it does the same thing again. Looks like the image's `npm ci` runs with only the root `package.json` and lockfile mounted, so the workspace packages' dependencies never make it into the image and every `docker run` reinstalls them. That's a separate PR, and a much bigger win than this one for that job; noting it here so the 380 isn't read as the ceiling. Chromatic and `test-storybook` are green with the `react-docgen` switch, and the Storybook build step time is unchanged (125 s vs 108 to 130 s on master). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
