rusackas opened a new pull request, #45602:
URL: https://github.com/apache/superset/pull/45602

   ### SUMMARY
   `.gitattributes` marks `*.ipynb binary` repo-wide. `Country Map GeoJSON 
Generator.ipynb` is the only notebook in the tree, so in practice this one rule 
means every change to it shows as "Binary files differ" in diffs and PR 
reviews, and conflicts fall back to an all-or-nothing ours/theirs choice 
instead of git's normal line-level 3-way merge.
   
   Removing it costs nothing here: the notebook is plain JSON text, there's 
exactly one small embedded plot image in the whole file (~62KB base64, one 
cell), and `*.svg`/`*.geojson` keep their own binary rules untouched.
   
   Verified in a disposable worktree: with the line removed, a one-line edit to 
the notebook shows as a normal 1-line diff instead of "Binary files differ".
   
   No functional change - this only affects how git displays/merges the file, 
not its contents.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A
   
   ### TESTING INSTRUCTIONS
   - Edit a single line inside the notebook and run `git diff` before/after 
this change - confirms the diff is now line-level and readable instead of 
"Binary files differ".
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to