Re: [PR] fix(csv): stop doubling backslashes in CSV exports [superset]

via GitHub Thu, 22 Oct 2026 00:11:58 -0700


codeant-ai-for-open-source[bot] commented on code in PR #45614:
URL: https://github.com/apache/superset/pull/45614#discussion_r4345502733



##########
superset/utils/csv.py:
##########
@@ -115,7 +116,13 @@ def escape_values(v: Any) -> Union[str, Any]:
                 if isinstance(value, str):
                     df.at[label, name] = escape_value(value)
 
-    return df.to_csv(escapechar="\\", **kwargs)
+    # An escape character makes the writer double every backslash in the data
+    # (C:\Users becomes C:\\Users). Only QUOTE_NONE, which cannot quote a
+    # delimiter or a line break, needs one; Python 3.10's writer also wanted 
one
+    # for a NUL character (#28755), which Python 3.11 writes without it.
+    if kwargs.get("quoting") == QUOTE_NONE:
+        kwargs.setdefault("escapechar", "\\")

Review Comment:
   **Suggestion:** `setdefault` preserves an explicitly configured 
`escapechar=None`; with `quoting=QUOTE_NONE`, a field containing a delimiter or 
newline then makes pandas raise “need to escape, but no escapechar set.”
   
   **Assessment:** 🟠 `Major` · 🔁 `Occurrence: Rarely` · 🏷️ `Api mismatch`
   
   [![Use CodeAnt 
Skill](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/use-codeant-skill-flat-v2.svg)](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
 [![Fix in 
Cursor](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-cursor-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=3e4ebfa46b16464fa2683f7324861aa1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
 [![Fix in VSCode 
Claude](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-vscode-claude-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=3e4ebfa46b16464fa2683f7324861aa1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset/utils/csv.py
   **Line:** 124:124
   **Comment:**
        *Api Mismatch: `setdefault` preserves an explicitly configured 
`escapechar=None`; with `quoting=QUOTE_NONE`, a field containing a delimiter or 
newline then makes pandas raise “need to escape, but no escapechar set.”
   
   Validate the correctness of the flagged issue. If correct, How can I resolve 
this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask 
user if the user wants to fix the rest of the comments as well. if said yes, 
then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45614&comment_hash=e32fc1f00aa5f535735a47827196bfeac8a7d7b76101196d3effa5d555dd9609&reaction=like'>👍</a>
 | <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45614&comment_hash=e32fc1f00aa5f535735a47827196bfeac8a7d7b76101196d3effa5d555dd9609&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] fix(csv): stop doubling backslashes in CSV exports [superset]

Reply via email to