villebro commented on code in PR #475:
URL:
https://github.com/apache/superset-kubernetes-operator/pull/475#discussion_r4350352607
##########
docs/user-guide/configuration.md:
##########
@@ -815,10 +828,12 @@ spec:
fsGroup: 1000
container:
securityContext:
- readOnlyRootFilesystem: true
+ readOnlyRootFilesystem: false
allowPrivilegeEscalation: false
```
+Keep `readOnlyRootFilesystem` unset or `false` for Superset components.
Superset writes to `/tmp` and `/app` at runtime, and Celery beat keeps its pid
and schedule files in `/tmp`.
Review Comment:
"Keep unset or `false`" makes it sound like a read-only root filesystem
can't work. The failures in your Kind run are all writes to `/tmp`, so an
`emptyDir` mounted at `/tmp` should fix them. Could you try that? If it works,
I'd rewrite the note to say "if you enable `readOnlyRootFilesystem`, mount an
`emptyDir` at `/tmp`."
Also:
- `/app` appears in the error only as Python's last fallback for temp files,
so it doesn't show Superset writes there. I'd drop it unless the test shows
otherwise.
- `readOnlyRootFilesystem: false` is already the default, so I'd remove it
from the example.
##########
docs/user-guide/installation.md:
##########
@@ -176,6 +176,8 @@ EOF
The operator will create parent-owned lifecycle task Jobs to perform database
migration and initialization, then create the web server Deployment, Service,
and ConfigMap. Check task status with `kubectl describe superset my-superset`.
+The official lean Superset image (e.g. `6.1.0`) has no database drivers. Set
`image` to a build that includes the driver for your connection URI, such as
`psycopg2` for `postgresql+psycopg2`. See
[Metastore](configuration.md#metastore) for driver details.
Review Comment:
Mental note: as of 7.0.0, this will change. So let's make sure we update
this when 7.0.0 is released. And on this note, as it will be difficult to
maintain compatibility for many major Superset versions (it would require lots
of case/switch type logic), I think it may make sense to start aligning the
operator's version with the main Superset version it's compatible with once the
operator is deemed stable. This will make it easier to maintain the operator,
keep the codebase lean and also be more understandable for end users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
