michael-s-molina commented on issue #45248: URL: https://github.com/apache/superset/issues/45248#issuecomment-6343482450
That makes sense, thanks. A real link for middle-click, open in new tab and a11y is a good reason to keep `page` on the navbar item, and it avoids special-casing a command id in the host. I'm fine with `page` staying. One naming suggestion: could we call the command `core.navigation.openPage` instead of `core.navigation.openView`? Not every view is a page, and the command only works for views registered at `global.page`, so `openPage` matches both the `page` field and the location. It also lines up with the `/extensions/pages/<id>` route. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
