sadpandajoe commented on PR #45306: URL: https://github.com/apache/superset/pull/45306#issuecomment-6351398587
Thanks for the careful review. Done: `renderTrigger` is removed from `metricsLayout` and `transposePivot` in 20d2343acf, and from `combineMetric` in d9c6268a9c (another review asked for that one too); the control test now covers all seven level-selecting controls. The branch was rebased onto master after your review and has since been brought up to date, and the checks you mentioned were infra failures: the required checks are green on the current head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
