Antonio-RiveroMartnez commented on code in PR #45550:
URL: https://github.com/apache/superset/pull/45550#discussion_r4360329373
##########
superset/extensions/storage/api.py:
##########
@@ -86,9 +86,18 @@ def _wire_value_for_request(value: Any, is_binary: bool) ->
Any:
class ExtensionStorageRestApi(BaseApi):
- """REST API for extension ephemeral (Tier 2) and persistent (Tier 3)
storage."""
+ """REST API for extension ephemeral (Tier 2) and persistent (Tier 3)
storage.
+
+ Docstring descriptions below use backticks rather than double quotes: FAB
+ re-parses each operation's parsed YAML through ``str(dict)``, and a value
+ that mixes ``'`` and ``"`` comes back with escapes YAML rejects, which
+ breaks ``/api/v1/_openapi`` and ``superset update-api-docs``.
+ """
allow_browser_login = True
+ # FAB's BaseApi exempts its blueprint from CSRF; the write routes are
+ # cookie-authenticated, so keep the protection.
+ csrf_exempt = False
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
