sadpandajoe commented on code in PR #45640:
URL: https://github.com/apache/superset/pull/45640#discussion_r4362720735
##########
superset-frontend/packages/superset-ui-core/src/components/ListViewCard/ImageLoader.tsx:
##########
@@ -57,7 +58,7 @@ export function ImageLoader({
useEffect(() => {
if (src) {
- fetch(src)
+ SupersetClient.get({ endpoint: src, parseMethod: 'raw' })
Review Comment:
Switching to `SupersetClient.get` changes the `fetch` call that the callers'
tests assert on: `SupersetClient` awaits `ensureAuth()` and then calls `fetch`
with an absolute URL and an options object. `DashboardCard.test.tsx`
(`thumbnail URL construction`, around lines 226-257) still expects a
synchronous `fetch('/api/v1/dashboard/<id>/thumbnail/<ts>/')` with no second
argument, and the `sharded-jest-tests (2)` check fails on exactly those two
assertions. Could you update them to wait for the request and match the new
`fetch` signature (or assert on `SupersetClient.get`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
