mikebridge commented on PR #45551: URL: https://github.com/apache/superset/pull/45551#issuecomment-6373783982
_AI-assisted reply on Mike's behalf._ Thanks, Matt. The comment and coverage nits are addressed: - The 409 comment covers both linking and unlinking and says that purge removes the chart's membership history, so the retry does not include it in `skipped_slice_ids`. - Added a test using a real failed SQLAlchemy flush against in-memory SQLite. It verifies that the entity is expired and that the log preserves the original `IntegrityError`, entity ID and transaction ID. Changing the logger back to `entity.id` makes the test fail with `PendingRollbackError`. - The unrelated-FK case's docstring explicitly calls the injected error simulated. The focused suite passes all 104 tests, and changed-file hooks pass. There are no executable production changes in this follow-up. I left ID reuse unchanged, as you suggested. I also deferred the optional uncommitted-purge interleaving; that needs a separate PostgreSQL/MySQL concurrency test and is not covered by this addition. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
