hughhhh commented on code in PR #43870:
URL: https://github.com/apache/superset/pull/43870#discussion_r4364060599
##########
superset/db_engine_specs/oracle.py:
##########
@@ -36,6 +36,7 @@
class OracleEngineSpec(BaseEngineSpec):
engine = "oracle"
engine_name = "Oracle"
+ select_without_from_suffix = " FROM DUAL"
Review Comment:
Good catch. Fixed in
[6f37942f48](https://github.com/apache/superset/pull/43870/commits/6f37942f48):
whether a key holds only days is now read from the database's own dialect,
which makes Oracle's `DATE` a `DateTime`, so the precision check runs and a
time-of-day bound is declined (an exact midnight still mirrors).
##########
superset/datasets/api.py:
##########
@@ -2064,6 +2165,134 @@ def get(self, id_or_uuid: str, **kwargs: Any) ->
Response:
entity_concurrency_token(SqlaTable, table.id, table.uuid),
)
+ @expose("/<int:pk>/partition_mapping/preview/", methods=("POST",))
+ @protect()
+ @safe
+ @statsd_metrics
+ @event_logger.log_this_with_context(
+ action=lambda self, *args, **kwargs: (
+ f"{self.__class__.__name__}.partition_mapping_preview"
+ ),
+ log_to_statsd=False,
+ )
+ def partition_mapping_preview(self, pk: int) -> Response:
Review Comment:
Fixed in
[6f37942f48](https://github.com/apache/superset/pull/43870/commits/6f37942f48):
a temporal sample is now previewed as a time range sends it (the typed
literal), the text shape is probed too, and the preview refuses a transform
whose two answers differ, showing both predicates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
