eschutho commented on PR #39285: URL: https://github.com/apache/superset/pull/39285#issuecomment-6375640865
Closing: QA against current master shows this is superseded. #43456 already renders ECharts canvases at 2x for the PNG export (crisp at DPR 1 and 2), and #44529 covers Safari. At DPR 1 this PR only stretches the 1x canvas bitmap, so axis/legend labels are no sharper, and label size relative to the chart is unchanged. The only remaining delta is 2x for the JPEG option, which isn't worth carrying given the merge conflicts. Thanks for the review, @rusackas. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
