mikebridge commented on PR #45641:
URL: https://github.com/apache/superset/pull/45641#issuecomment-6376732397
_AI-assisted comment on Mike's behalf._
Follow-up from a product acceptance pass on this PR (f5e815b0a2, 68066ff322):
- **Rows with no saved snapshot are now plain history entries.** They no
longer have a button role, tab stop, click or keyboard handler, pointer cursor
or hover highlight, and they show "No saved version to preview". Rows with a
saved version keep their existing actions.
- **Docs.** `version-history.mdx` now explains which rows can be previewed,
and no longer says every field-change row previews the version.
- **Logging.**
- A `WARNING` is logged when a version GET returns 404 (entity type,
entity id, version UUID).
- A `DEBUG` count is logged when an activity page contains rows without a
snapshot. That count stays at DEBUG because those rows are now expected and
handled, so a warning on every page load would be noise.
- **Chart names:** membership-only records carry chart IDs, not names, so
this doesn't add a lookup to show them.
The new tests failed before the change and pass after it. 144 focused
backend tests and 81 frontend tests pass, along with changed-file hooks and the
translation drift check. Restore behaviour and snapshot capture are unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
