codeant-ai-for-open-source[bot] commented on code in PR #45553:
URL: https://github.com/apache/superset/pull/45553#discussion_r4365120777
##########
superset/utils/network.py:
##########
@@ -260,3 +265,161 @@ def is_host_up(host: str) -> bool:
return False
return output == 0
+
+
+class ConnectionDeadline(Protocol):
+ """A caller-owned deadline; socket code does not choose request policy."""
+
+ def remaining(self) -> float: ...
+ def watch(self, sock: socket.socket) -> None: ...
+
+
+PROVIDER_DEADLINE: ContextVar[ConnectionDeadline | None] = ContextVar(
+ "provider_connection_deadline", default=None
+)
+_RESOLVER: ThreadPoolExecutor | None = None
+_RESOLVER_LOCK: Lock = Lock()
+
+
+class NonPublicAddressError(OSError):
+ """Resolution included an address refused by the shared destination
rules."""
+
+
+def _resolve_addresses(
+ host: str, port: int, timeout: float, *, public_only: bool
+) -> list[str]:
+ """Bound waiting and pin the complete answer set before any connection."""
+ global _RESOLVER # pylint: disable=global-statement
+ if timeout <= 0:
+ raise TimeoutError
+ with _RESOLVER_LOCK:
+ if _RESOLVER is None:
+ _RESOLVER = ThreadPoolExecutor(8, "provider-dns")
+ lookup: Future[Any] = _RESOLVER.submit(
+ socket.getaddrinfo, host, port, socket.AF_UNSPEC,
socket.SOCK_STREAM
+ )
+ try:
+ answers: Any = lookup.result(timeout=timeout)
+ finally:
+ lookup.cancel() # Queued work is disposable; running system DNS
cannot stop.
Review Comment:
**Suggestion:** When eight system DNS calls stall, `Future.cancel()` cannot
stop running lookups; the shared pool stays exhausted, so otherwise valid
provider requests queue and time out.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Performance`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=2aaf4563aa4c4d2b82267131b66700bb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=2aaf4563aa4c4d2b82267131b66700bb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/utils/network.py
**Line:** 296:304
**Comment:**
*Performance: When eight system DNS calls stall, `Future.cancel()`
cannot stop running lookups; the shared pool stays exhausted, so otherwise
valid provider requests queue and time out.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45553&comment_hash=1763f18604ffc6b7a673f883122aa3fe6f7a1ce1546c74d205ec4fb0715eb06a&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45553&comment_hash=1763f18604ffc6b7a673f883122aa3fe6f7a1ce1546c74d205ec4fb0715eb06a&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
