rusackas commented on code in PR #42910:
URL: https://github.com/apache/superset/pull/42910#discussion_r4365587076
##########
superset-frontend/src/explore/components/controls/ColorPickerControl.tsx:
##########
@@ -163,6 +198,12 @@ export default function ColorPickerControl({
return customPresets.map(item => ({
label: item.label,
colors: item.colors.map(color => {
+ if (resolveThemeTokens && color in SPECIAL_COLORS) {
+ // Share the trigger's lookup so the preset chip matches it.
+ return (
+ toDisplayHex(color as string, themeColors, true) ?? String(color)
+ );
+ }
Review Comment:
Good catch. handleChange now compares against toDisplayHex(key, themeColors,
true), so the chip maps back to Green/Red. Updated the FormattingPopoverContent
test to match.
##########
superset/translations/messages.pot:
##########
@@ -10274,6 +10323,13 @@ msgstr ""
msgid "Physical (table or view)"
msgstr ""
+msgid ""
+"Pick a color for each interval band defined above by its upper bound. "
+"Charts saved with the legacy 1-indexed \"Interval colors\" text field are"
Review Comment:
Fixed the msgid typo in messages.pot so it matches the Gauge help text.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
