aminghadersohi commented on PR #45571: URL: https://github.com/apache/superset/pull/45571#issuecomment-6379843948
@rebenitez1802 I checked the approval body; its only remaining suggestion is the legacy semantic-view grain compatibility covered by the two inline threads. Fixed in ba1e5ab959efee70bda288c11dea823bd795fd92. The mirror preserves the grain when the saved lookup is absent or null, but still removes it for an explicit empty lookup. Regression: `tests/unit_tests/common/test_form_data_query_context.py::test_legacy_sunburst_dashboard_grain_without_lookup` exercises the shared builder, export fallback, and MCP dashboard override; `tests/unit_tests/semantic_layers/mapper_test.py::test_legacy_sunburst_dashboard_grain_reaches_semantic_mapper` asserts the mapped temporal dimension's grain. Missing/null cases failed on the pre-fix head (8 failures); all 916 selected Python tests pass after in Docker. The matching frontend regression also fails before and passes after (150 branch Jest tests pass). Siblings checked: - superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/buildQuery.ts:73 — fixed in ba1e5ab959efee70bda288c11dea823bd795fd92 - superset/common/form_data_query_context.py:647 — fixed in ba1e5ab959efee70bda288c11dea823bd795fd92 - superset/mcp_service/chart/chart_helpers.py:1243 — fixed in ba1e5ab959efee70bda288c11dea823bd795fd92 - superset/common/form_data_query_context.py:1773 — fixed in ba1e5ab959efee70bda288c11dea823bd795fd92 - superset/semantic_layers/mapper.py:1351 — not affected: already infers a single temporal dimension when the grain is retained; pinned by test_legacy_sunburst_dashboard_grain_reaches_semantic_mapper. - superset/common/form_data_query_context.py:580 — not affected: pivot temporalization does not remove the extras grain. - superset/common/form_data_query_context.py:660 — not affected: box-plot temporalization does not remove the extras grain. - superset/common/form_data_query_context.py:682 — not affected: table temporalization does not use the Sunburst grain-removal branch. - superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/timeGrain.ts — not affected: drill/label selection does not remove query extras; inferring semantic dimension types on the client is outside this compatibility change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
